feature(IE Postal): add postal code for Ireland #1083
Conversation
ezkemboi
commented
Aug 11, 2019
ezkemboi
commented
- Add postal code for Ireland as requested by @JoeEarly from issue Customise postcode validation #784
- Fixes request done on issue Customise postcode validation #784
src/lib/isPostalCode.js
Outdated
| @@ -28,6 +28,7 @@ const patterns = { | |||
| HR: /^([1-5]\d{4}$)/, | |||
| HU: fourDigit, | |||
| ID: fiveDigit, | |||
| IE: /^[a-zA-Z0-9]{3}\b \b[a-zA-Z0-9]{4}$/i, | |||
There was a problem hiding this comment.
Simplified regex would be:
/^\w{3}\s\w{4}$/i\w will match any alphanumeric, see a good quick ref here.
However, it also looks to me like most of the areas, the routing key is in the format of [alpha][digit][digit] except for Dublin 6W, so we could make it more specific?
/^[A-z]\d[\d|W]\s\w{4}$/inb: the i can be left out too since the regex is wide enough.
There was a problem hiding this comment.
Checking on this @profnandaa.
There was a problem hiding this comment.
There was a problem hiding this comment.
Also, \s will match tab and new line,
Should we allow for tabs and a new line for separation?
There was a problem hiding this comment.
Sure, you we could just do an actual space.
profnandaa
added
the
🧹 needs-update
- add postal code for ireland as requested by @JoeEarly from issue validatorjs#784 - fixes request done on issue validatorjs#784
ezkemboi
force-pushed
the
add-ireland-postal-code
branch
from
b5515a6
to
0fe9155
Compare
|
@profnandaa updates made as requested. |
|
And as always, thanks for the PR, Ez! 🎉 |
