add regex for en-MO (Macau phone numbers - +853-6123-4567) #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezkemboi
reviewed
Sep 5, 2019
src/lib/isMobilePhone.js
Outdated
| @@ -28,6 +28,7 @@ const phones = { | |||
| 'en-IE': /^(\+?353|0)8[356789]\d{7}$/, | |||
| 'en-IN': /^(\+?91|0)?[6789]\d{9}$/, | |||
| 'en-KE': /^(\+?254|0)(7|1)\d{8}$/, | |||
| 'en-MO': /^(\+?853\-?)?6\d{3}\-?\d{4}$/, | |||
There was a problem hiding this comment.
Good work adding this new feature.
I just wanted to leave some comments,
- Add tests for the same (Valid and invalid cases).
- Update the README file to help people that the new mobile validation is available.
- Run your tests.
In case of any clarification, feel free to ask/check readme.md file for more clarification.
ezkemboi
requested changes
Oct 14, 2019
There was a problem hiding this comment.
@anton-bot Check my requests in the comment above and I think the PR will be ready to land unless @profnandaa have some comments or requests.
|
@ezkemboi thanks for your advice, added tests and updated readme now. |
|
superceded by #1200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.