Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ecuador phone number validator #1187

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Add Ecuador phone number validator #1187

merged 2 commits into from
Oct 29, 2019

Conversation

mmena1
Copy link
Contributor

@mmena1 mmena1 commented Oct 28, 2019

This will add Ecuador phone number validation according to https://en.wikipedia.org/wiki/Telephone_numbers_in_Ecuador .
Closes #1186

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contrib! 🎉

@profnandaa profnandaa merged commit 5907752 into validatorjs:master Oct 29, 2019
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrcrow85 according to ITU document about ecudator National Numbering Plans 9 digits number are only valid if the first digit is 9

  • +593 987654321 is valid
  • +593 287654321 is not valid (New network code always starts with 9)
  • +591 912345678 is not valid (New network code is between 92 and 99)
    Can you confirm that?

@mmena1
Copy link
Contributor Author

mmena1 commented Oct 29, 2019

@mrcrow85 according to ITU document about ecudator National Numbering Plans 9 digits number are only valid if the first digit is 9

* +593 987654321 is valid

* +593 287654321 is not valid (New network code always starts with 9)

* +591 912345678 is not valid (New network code is between 92 and 99)
  Can you confirm that?

@tux-tn Oh, good catch! You are right, 9 digits numbers are only valid if the first digit is 9. As for the network code between 92 and 99, I read the legal resolution (which is in Spanish) which states that 0 and 1 are reserved numbers so 90 and 91 are invalid.

I will open an issue to address this followed by a PR to fix it.

@mmena1 mmena1 deleted the add-ecuador-phone-number-validation branch October 29, 2019 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ecuador (+593) phone number validation
3 participants