Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Spanish postal code and mobile phone #1204

Closed
wants to merge 0 commits into from
Closed

fix: Spanish postal code and mobile phone #1204

wants to merge 0 commits into from

Conversation

r2bapps
Copy link

@r2bapps r2bapps commented Nov 21, 2019 •
edited
Loading

Spanish ZIP codes are between 01001 and 52999.

  • Replaced regex with validation function.
  • Improved tests.

Spanish mobile phones starts with 6 or 7 and next digits have no restrictions.

  • Fixed regex with no restrictions.
  • Improved tests: 754789321 should be valid and was setted as invalid

tux-tn
tux-tn requested changes Nov 21, 2019
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes concerning the isMobilePhone validator in /lib and /es/lib are missing. All else looks good, great job 👍

@r2bapps r2bapps closed this Nov 22, 2019
@r2bapps
Copy link
Author

r2bapps commented Nov 22, 2019

Moved to a new branch, sorry for the inconvenience.

This was referenced May 28, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tux-tn tux-tn tux-tn requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r2bapps @tux-tn