Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow spaces in Hong Kong and Macau phone numbers #1213

Merged
merged 1 commit into from
Dec 10, 2019
Merged

allow spaces in Hong Kong and Macau phone numbers #1213

merged 1 commit into from
Dec 10, 2019

Conversation

anton-bot
Copy link
Contributor

  1. Allow spaces in Hong Kong and Macau phone numbers, because in the overwhelming majority of cases the numbers are written like:

+853 6123 4567
+852 9123 4567

Reference: https://en.wikipedia.org/wiki/Telephone_numbers_in_Hong_Kong

  1. Disallow phone numbers starting from 2 and 8 in Macau, because they are not mobile phones (they are landlines).

Reference: https://en.wikipedia.org/wiki/Telephone_numbers_in_Macau

profnandaa
profnandaa approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contrib! 🎉

@profnandaa profnandaa merged commit 0b9f593 into validatorjs:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anton-bot @profnandaa