Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added postal code for nepal #1317

Merged
merged 2 commits into from
May 27, 2020
Merged

Added postal code for nepal #1317

merged 2 commits into from
May 27, 2020

Conversation

parasg1999
Copy link
Contributor

The passport file changes are related to the addition of indian passports #1313

profnandaa
profnandaa requested changes May 27, 2020
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the unrelated change for isPassportNumber (perhaps you didn't rebase).

Thanks for this though, looks good.

@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label May 27, 2020
@parasg1999
Copy link
Contributor Author

parasg1999 commented May 27, 2020 •
edited
Loading

@profnandaa Actually, I didn't push those files earlier.

@profnandaa
Copy link
Member

Can just unstage them from the PR.

@parasg1999
Copy link
Contributor Author

@profnandaa Removed the isPassportNumber changes

@profnandaa
Copy link
Member

@parasg1999 -- one last change, the README.

@parasg1999
Copy link
Contributor Author

@profnandaa Done!

profnandaa
profnandaa approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@profnandaa profnandaa merged commit 678b52a into validatorjs:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parasg1999 @profnandaa