Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added RU to isPassportNumber #1467

Merged
merged 5 commits into from
Oct 8, 2020
Merged

added RU to isPassportNumber #1467

merged 5 commits into from
Oct 8, 2020

Conversation

dkochetkov
Copy link
Contributor

@dkochetkov dkochetkov commented Oct 6, 2020

Added RU to isPassportNumber fo check Russian passport series & number (00 00 000000 || 0000 000000 || 0000000000).

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #1467 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1467   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          96       96           
  Lines        1275     1275           
=======================================
  Hits         1274     1274           
  Misses          1        1           
Impacted Files Coverage Δ
src/lib/isPassportNumber.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 121547d...0c6a655. Read the comment docs.

@profnandaa
Copy link
Member

@dkochetkov - thanks for your PR! Could you please remove all the other unrelated changes?

@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Oct 7, 2020
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants