-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isMobilePhone): add ar-MA locale #1521
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1521 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 96 96
Lines 1286 1286
=======================================
Hits 1285 1285
Misses 1 1
Continue to review full report at Codecov.
|
@@ -12,6 +12,7 @@ const phones = { | |||
'ar-JO': /^(\+?962|0)?7[789]\d{7}$/, | |||
'ar-KW': /^(\+?965)[569]\d{7}$/, | |||
'ar-LY': /^((\+?218)|0)?(9[1-6]\d{7}|[1-8]\d{7,9})$/, | |||
'ar-MA': /^(?:(?:\+|00)212|0)[5-7]\d{8}$/, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests for this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fix conflicts and this is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contrib! 🎉
Thank you 👍 |
Added ar-MA locale to validate Moroccan mobile phones.
Checklist