Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Malaysian Passport validation #1574

Merged
merged 4 commits into from
Mar 12, 2021

Conversation

stranger26
Copy link
Contributor

Added Malaysian Passport validation

Republish of #1501

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@stranger26 stranger26 mentioned this pull request Jan 6, 2021
3 tasks
tux-tn
tux-tn previously approved these changes Feb 26, 2021
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted ignored validator.min.js and validator.js to fix conflict. We should be able to merge. Thank you for your contribution LGTM 🎉

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #1574 (8943b19) into master (7989e5b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1574   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          100       100           
  Lines         1843      1843           
=========================================
  Hits          1843      1843           
Impacted Files Coverage Δ
src/lib/isPassportNumber.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7989e5b...8943b19. Read the comment docs.

@profnandaa
Copy link
Member

@stranger26 -- please fix the merge conflicts on README and we should be good to go.

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Mar 12, 2021
@profnandaa
Copy link
Member

That was fast, thanks!

@profnandaa profnandaa merged commit bb0dba6 into validatorjs:master Mar 12, 2021
@stranger26 stranger26 deleted the MY_Passport branch March 16, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mc-to-land Just merge-conflict standing between the PR and landing. needs-more-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants