Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Libya Passport and Identity Number Validation #1583

Merged
merged 3 commits into from
Feb 28, 2021

Conversation

asghaier76
Copy link
Contributor

@asghaier76 asghaier76 commented Jan 25, 2021

{{ Adding validation for Libyan Passport Number and Libyan Identity Number }}

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@asghaier76 asghaier76 changed the title Added Libya Passort and Identity Number Validation Added Libya Passport and Identity Number Validation Jan 25, 2021
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #1583 (bb00fa6) into master (8831db3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1583   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          100       100           
  Lines         1796      1798    +2     
=========================================
+ Hits          1796      1798    +2     
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)
src/lib/isPassportNumber.js 100.00% <ø> (ø)
src/lib/isDataURI.js 100.00% <100.00%> (ø)
src/lib/isIdentityCard.js 100.00% <100.00%> (ø)
src/lib/isMACAddress.js 100.00% <100.00%> (ø)
src/lib/isStrongPassword.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8831db3...7a85ae8. Read the comment docs.

tux-tn
tux-tn previously approved these changes Jan 29, 2021
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats for your first contrib 🎉
LGTM

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted ignored validator.min.js and validator.js to fix conflict. We should be able to merge. Thank you again for your contribution

@profnandaa profnandaa merged commit 2331120 into validatorjs:master Feb 28, 2021
@profnandaa
Copy link
Member

Thanks for your PR @asghaier76 and welcome to the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants