feat(isXRPAddress): add validator #1631
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1631 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 100 101 +1
Lines 1843 1859 +16
=========================================
+ Hits 1843 1859 +16
Continue to review full report at Codecov.
|
| export default function isXRPAddress(address, options) { | ||
| assertString(address); | ||
|
|
||
| if (typeof (options) !== 'object') { |
There was a problem hiding this comment.
I can say, even typeof (null) === object.
One of the best ways to check object type is to check its prototype ie.
Object.prototype.toString.call(option).toLowerCase(), most of the case is that the second part after space is the type.
I think I will add a validator to check the type
| return classicAddressRegex.test(address); | ||
| } | ||
|
|
||
| if (typeof (options.xAddress) !== 'object') { |
There was a problem hiding this comment.
I have written that help us make a robust code here, #1648
|
BTW, is XRP a standard or proprietary? |
|
what is the latest status here? |
Issue: #1630
Added new validator that will check if string is valid XRP address.
Added test to check this new validator
Update readme and add documentation regarding this new validator
Checklist