-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ReDOS in isEmail and isHSL #1651
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1651 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 100 101 +1
Lines 1847 1854 +7
=========================================
+ Hits 1847 1854 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this in! LGTM.
This PR updates
isEmail
andisHSL
in order to prevent ReDOS attack described in #1597 and #1598 without changing the behaviour of both validators.mocha
has also been updated to the latest version in order to prevent npm/yarn audit from displaying a warning (Mocha is used as a dev dependency, people using validator are not impacted)Checklist