Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isISO4217): add currency code validator (#1703) #1706

Merged
merged 3 commits into from
Sep 26, 2021

Conversation

jmpaya
Copy link
Contributor

@jmpaya jmpaya commented Aug 12, 2021

Add currency code validator

  • Created ISO 4217 validator using all officially assigned currency codes obtained from this list.

  • Create a test suite with some valid and some invalid currency codes.

  • Update README file adding the new validator.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #1706 (dc9042b) into master (8c4b3b3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1706   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          101       102    +1     
  Lines         2005      2012    +7     
  Branches       452       452           
=========================================
+ Hits          2005      2012    +7     
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)
src/lib/isISO4217.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4b3b3...dc9042b. Read the comment docs.

src/lib/isISO4217.js Outdated Show resolved Hide resolved
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job @jpaya17

@tux-tn tux-tn added 🎉 first-pr ready-to-land For PRs that are reviewed and ready to be landed labels Aug 20, 2021
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contrib! 🎉

@profnandaa profnandaa merged commit f34112d into validatorjs:master Sep 26, 2021
@xmookiwa
Copy link

12125511800

@xmookiwa
Copy link

f34112d

@xmookiwa
Copy link

Thanks for your contrib! 🎉

@xmookiwa
Copy link

Thanks for your contrib! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants