Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isMobilePhone): add Frech Polynesia fr-PF locale #1797

Closed
wants to merge 1 commit into from
Closed

feat(isMobilePhone): add Frech Polynesia fr-PF locale #1797

wants to merge 1 commit into from

Conversation

hereje
Copy link
Contributor

@hereje hereje commented Oct 16, 2021

feat(isMobilePhone): Add validation for frech polynesia mobile phones

Create validation for frech polynesia mobile phones according to wikipedia:
https://en.wikipedia.org/wiki/Telephone_numbers_in_French_Polynesia#Mobile

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

Related to #1761

@codecov
Copy link

codecov bot commented Oct 16, 2021

Codecov Report

Merging #1797 (d0d1b6f) into master (13651ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1797   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2029      2029           
  Branches       457       457           
=========================================
  Hits          2029      2029           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13651ea...d0d1b6f. Read the comment docs.

@hereje hereje changed the title feat(isMobilePhone): Add validation for frech polynesia mobile phones feat(isMobilePhone): Add validation for frech polynesia mobile phones ['fr-PF'] Oct 16, 2021
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank you for your PR @hereje

@tux-tn tux-tn added hacktoberfest-accepted ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr labels Oct 27, 2021
@profnandaa
Copy link
Member

@hereje -- Please fix the merge conflict and we should be good to go.

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Oct 30, 2021
@profnandaa profnandaa changed the title feat(isMobilePhone): Add validation for frech polynesia mobile phones ['fr-PF'] feat(isMobilePhone): add Frech Polynesia fr-PF locale Oct 31, 2021
@profnandaa
Copy link
Member

No worries, your commit is now included here #1851

@profnandaa profnandaa closed this Oct 31, 2021
@hereje hereje deleted the feat/mobile-phone/frech-polynesia branch February 13, 2022 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr hacktoberfest-accepted mc-to-land Just merge-conflict standing between the PR and landing. ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants