feat(contains): Added possibility to check that string contains seed multiple times #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1836 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2029 2030 +1
Branches 457 459 +2
=========================================
+ Hits 2029 2030 +1
Continue to review full report at Codecov.
|
profnandaa
added
needs-more-review
ready-to-land
tux-tn
reviewed
Oct 30, 2021
|
@tux-tn -- need your final ✅ |
tux-tn
approved these changes
Oct 30, 2021
There was a problem hiding this comment.
LGTM 🎉
Thank you @Marcholio for all your recent contributions ❤️
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
…ltiple times (#1836) * Added feature to require minimum number of occurrences for the seed in 'contains' * Changed regex to split Co-authored-by: Markus Tyrkkö <markus.tyrkko@nitor.com> Co-authored-by: Markus <markus.tyrkko@gmail.com>
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
…ltiple times (#1836) * Added feature to require minimum number of occurrences for the seed in 'contains' * Changed regex to split Co-authored-by: Markus Tyrkkö <markus.tyrkko@nitor.com> Co-authored-by: Markus <markus.tyrkko@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
containsnow checks if the string contains the seed n number of times, eg. foobarfoobar contains foo 2 times. This functionality is enabled by providing minOccurrences option (defaults to 1). Also refactored the implementation to be based on regex, rather than indexOf.Checklist