Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(isMobilePhone): Add mobile phone validation locale for Tajikistan (tg-TJ) #1846

Merged
merged 1 commit into from
Oct 31, 2021
Merged

feat(isMobilePhone): Add mobile phone validation locale for Tajikistan (tg-TJ) #1846

merged 1 commit into from
Oct 31, 2021

Conversation

mgnss
Copy link
Contributor

@mgnss mgnss commented Oct 30, 2021 •
edited
Loading

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #1846 (306923f) into master (5773869) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1846   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2052      2052           
  Branches       463       463           
=========================================
  Hits          2052      2052
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5773869...306923f. Read the comment docs.

tux-tn
tux-tn approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Thank you for your PR @mgnss

@tux-tn tux-tn added hacktoberfest-accepted ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr labels Oct 30, 2021
profnandaa
profnandaa approved these changes Oct 31, 2021
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉

@profnandaa profnandaa merged commit 01d3da3 into validatorjs:master Oct 31, 2021
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
@mgnss @profnandaa
feat(isMobilePhone): add Tajikistan tg-TJ locale (#1846)
71206bf
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
@mgnss @profnandaa
feat(isMobilePhone): add Tajikistan tg-TJ locale (#1846)
1c56d5b
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
@mgnss @profnandaa
feat(isMobilePhone): add Tajikistan tg-TJ locale (#1846)
f151e47
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
@mgnss @profnandaa
feat(isMobilePhone): add Tajikistan tg-TJ locale (#1846)
ed60123
@profnandaa profnandaa mentioned this pull request Oct 31, 2021
Closed
@WikiRik WikiRik mentioned this pull request Jan 28, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tux-tn tux-tn tux-tn approved these changes

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
🎉 first-pr hacktoberfest-accepted ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgnss @profnandaa @tux-tn