Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Kazakhstan Phone #1924

Merged
merged 4 commits into from
Jul 19, 2022
Merged

Adding Kazakhstan Phone #1924

merged 4 commits into from
Jul 19, 2022

Conversation

arsalanfiroozi
Copy link
Contributor

Solved and added test for issue #1911

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #1924 (843240f) into master (e483f6a) will not change coverage.
The diff coverage is n/a.

❗ Current head 843240f differs from pull request most recent head 374a0b7. Consider uploading reports for the commit 374a0b7 to get more accurate results

@@            Coverage Diff            @@
##            master     #1924   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       102    -2     
  Lines         2120      2072   -48     
  Branches       475       472    -3     
=========================================
- Hits          2120      2072   -48     
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)
src/index.js 100.00% <0.00%> (ø)
src/lib/isIP.js 100.00% <0.00%> (ø)
src/lib/alpha.js 100.00% <0.00%> (ø)
src/lib/isURL.js 100.00% <0.00%> (ø)
src/lib/isTaxID.js 100.00% <0.00%> (ø)
src/lib/isBase32.js 100.00% <0.00%> (ø)
src/lib/isLength.js 100.00% <0.00%> (ø)
src/lib/isMagnetURI.js 100.00% <0.00%> (ø)
src/lib/isCreditCard.js 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e483f6a...374a0b7. Read the comment docs.

Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rosskhanas
Copy link

Any chance to have it merged?

rubiin
rubiin previously approved these changes Mar 18, 2022
@rubiin
Copy link
Member

rubiin commented Mar 18, 2022

@profnandaa

@profnandaa profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. 🎉 first-pr labels Apr 22, 2022
profnandaa
profnandaa previously approved these changes Apr 22, 2022
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge this soon.

// And sorry for the late review on this.

@rubiin rubiin dismissed stale reviews from profnandaa and themself via 374a0b7 July 19, 2022 16:41
@rubiin rubiin merged commit c8c247c into validatorjs:master Jul 19, 2022
@rubiin
Copy link
Member

rubiin commented Jul 19, 2022

Thankyou for the contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr mc-to-land Just merge-conflict standing between the PR and landing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants