Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Modify pattern of pt-Br regex #1951

Merged
merged 1 commit into from
Jun 30, 2022
Merged

fix: Modify pattern of pt-Br regex #1951

merged 1 commit into from
Jun 30, 2022

Conversation

matheusnascgomes
Copy link
Contributor

@matheusnascgomes matheusnascgomes commented Mar 31, 2022 •
edited
Loading

A brazilian cellphone number can start with "1" after its country code and local code

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@matheusnascgomes
fix: Modify pattern of pt-Br regex
06f9919 
- A Brazilian cellphone number can start with 1 after its country code and local code
- Fix test case to accept +55 11 91431-4567 and similar ones as valid

Signed-off-by: Matheus Gomes <matheusnascgomes@gmail.com>
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #1951 (06f9919) into master (c1b21a9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1951   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2085      2085           
  Branches       472       472           
=========================================
  Hits          2085      2085
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b21a9...06f9919. Read the comment docs.

tux-tn
tux-tn approved these changes Apr 24, 2022
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @matheusnascgomes
Thank you for your PR ! LGTM 🎉

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr labels Apr 24, 2022
@matheusnascgomes
Copy link
Contributor Author

Hi @tux-tn ! Any plans on merging this PR?

profnandaa
profnandaa approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Ref: #1407

@profnandaa profnandaa merged commit 47443d1 into validatorjs:master Jun 30, 2022
@profnandaa profnandaa mentioned this pull request Feb 2, 2023
Closed
@rntvicente rntvicente mentioned this pull request May 24, 2024
Open
@sahilpawar58 sahilpawar58 mentioned this pull request May 25, 2024
Open
@ChinmoyHembram ChinmoyHembram mentioned this pull request May 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tux-tn tux-tn tux-tn approved these changes

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
🎉 first-pr ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matheusnascgomes @profnandaa @tux-tn