-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed missing SK locale for isPostalCode #1957
Fixed missing SK locale for isPostalCode #1957
Conversation
In source code you already support SK locale for few years, but it was missing in documentation. validator.js/src/lib/isPostalCode.js
Codecov Report
@@ Coverage Diff @@
## master #1957 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 103 103
Lines 2099 2099
Branches 474 474
=========================================
Hits 2099 2099 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Thank you for your PR @tfilo
LGTM 🎉
Thanks for the catch, sorry we've a merge conflict coz of the other PR changes. Could you update? |
I did merge of master into my branch. Now it should have no conflict. |
In source code you already support SK locale for few years, but it was missing in documentation.
validator.js/src/lib/isPostalCode.js
Fixed missing SK locale for isPostalCode in readme file.
Fixed missing SK locale for isPostalCode in readme file.
Checklist