Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing SK locale for isPostalCode #1957

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Fixed missing SK locale for isPostalCode #1957

merged 2 commits into from
Jun 30, 2022

Conversation

tfilo
Copy link
Contributor

@tfilo tfilo commented Apr 17, 2022

In source code you already support SK locale for few years, but it was missing in documentation.
validator.js/src/lib/isPostalCode.js

Fixed missing SK locale for isPostalCode in readme file.

Fixed missing SK locale for isPostalCode in readme file.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

In source code you already support SK locale for few years, but it was missing in documentation. 
validator.js/src/lib/isPostalCode.js
@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #1957 (9e04886) into master (0175670) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1957   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       103           
  Lines         2099      2099           
  Branches       474       474           
=========================================
  Hits          2099      2099           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0175670...9e04886. Read the comment docs.

tux-tn
tux-tn previously approved these changes Apr 24, 2022
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you for your PR @tfilo
LGTM 🎉

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr labels Apr 24, 2022
@profnandaa
Copy link
Member

Thanks for the catch, sorry we've a merge conflict coz of the other PR changes. Could you update?

@tfilo
Copy link
Contributor Author

tfilo commented Jun 30, 2022

Thanks for the catch, sorry we've a merge conflict coz of the other PR changes. Could you update?

I did merge of master into my branch. Now it should have no conflict.

@profnandaa profnandaa merged commit 37cbd5c into validatorjs:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants