-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isAlpha, isAlphanumeric): add Japanese locale(ja-JP) #2014
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2014 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2203 2203
Branches 477 477
=========================================
Hits 2203 2203
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contrib! 🎉 I'd never noticed that we didn't have ja-JP locale for isAlpha/numeric.
Hey guys, I'm wondering when that will be published as a next release version?
|
Hello!
I added Japanese locale(ja-JP) to isAlpha/isAlphanumeric.
Please review my PR!!
Thanks in advance.
Checklist