Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isAlpha, isAlphanumeric): add Japanese locale(ja-JP) #2014

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

starcharles
Copy link
Contributor

Hello!
I added Japanese locale(ja-JP) to isAlpha/isAlphanumeric.
Please review my PR!!

Thanks in advance.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #2014 (c6905f5) into master (1bb14e8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #2014   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2203      2203           
  Branches       477       477           
=========================================
  Hits          2203      2203           
Impacted Files Coverage Δ
src/lib/alpha.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@starcharles starcharles marked this pull request as ready for review August 3, 2022 22:59
@rubiin rubiin added ready-to-land For PRs that are reviewed and ready to be landed ✅ LGTM labels Aug 4, 2022
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉 I'd never noticed that we didn't have ja-JP locale for isAlpha/numeric.

@profnandaa profnandaa merged commit d698f4f into validatorjs:master Oct 17, 2022
@nshaikhinurov
Copy link

Hey guys, I'm wondering when that will be published as a next release version?

LGTM, thanks for your contrib! 🎉 I'd never noticed that we didn't have ja-JP locale for isAlpha/numeric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr ✅ LGTM ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants