Add Belarusian [be-BY] and Romanian [ro-RO] to isAlpha and IsAlphanum… #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2023 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2203 2203
Branches 477 477
=========================================
Hits 2203 2203
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@rubiin @profnandaa @ezkemboi when you can, please review this new PR. Thank you! |
WikiRik
reviewed
Aug 10, 2022
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
@WikiRik This is one of the sources I used |
|
@profnandaa and @rubiin , is there someone we can add to review and approve this PR? Thank you! |
|
I will do some reviews
…On Sat, Sep 17, 2022, 9:26 PM Brian Whaley ***@***.***> wrote:
@braaar <https://github.com/braaar> @profnandaa
<https://github.com/profnandaa> @rubiin <https://github.com/rubiin>
@chriso <https://github.com/chriso> @ezkemboi
<https://github.com/ezkemboi> @tux-tn <https://github.com/tux-tn>
This PR is open for almost 2 months. It would be helpful for me and my
team if we could review and close this PR. What can I do to get this over
the finish line? Thank you!
—
Reply to this email directly, view it on GitHub
<#2023 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALVWPHY35QHO54GK5QHNJUTV6YEOFANCNFSM56FE5HNQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
profnandaa
added
mc-to-land
|
@brianwhaley can you fix the merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Belarusian [be-BY] and Romanian [ro-RO] to isAlpha and IsAlphanumeric