-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(isLocale): add support for validation of more valid language tags #2189
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2189 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 106 106
Lines 2348 2359 +11
Branches 593 592 -1
=========================================
+ Hits 2348 2359 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contrib @kwahome ! 🎉
feat(isLocale): Add support for validation of more valid language tags
Implement RFC 5646 compliant regex to validate language tags and locales.
Fix for #2100
Checklist