Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #2438 isEmail Issue #2446

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Vinayak-Nevge
Copy link

#2445 fixed(isEmail): Correct validation for invalid characters in quoted strings

This PR addresses the issue described in issue #2438, where email addresses with invalid characters such as * and . enclosed within double quotes were incorrectly validated as valid. The isEmail function's regular expression for quoted strings was updated to comply with RFC 5321, allowing only valid characters within quotes.

**References

Checklist

  • PR contains only changes related to the issue.
  • Tests updated to cover new cases (emails like "example*."@gmail.com are now rejected).
  • References provided in PR.

@gshpychka
Copy link

This PR addresses the issue described in #2438, where email addresses with invalid characters such as * and . enclosed within double quotes were incorrectly validated as valid.

They're correctly validated as valid, though - why do you say it's incorrect? https://en.wikipedia.org/wiki/Email_address#Local-part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants