-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow spaces for a TLD part #677
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@IVikulin - just fix the merge conflict on the |
@profnandaa done |
Name | Hex | JavaScript ------------------------------------------------------ space 0x20 \s en space 0x2002 \u2002 em space 0x2003 \u2003 three-per-em space 0x2004 \u2004 four-per-em space 0x2005 \u2005 six-per-em space 0x2006 \u2006 figure space 0x2007 \u2007 punctuation space 0x2008 \u2008 thin space 0x2009 \u2009 hair space 0x200A \u200A zero width space 0x200B \u200B narrow no-break space 0x202F \u202F medium mathematical space 0x205F \u205F ideographic space 0x3000 \u3000 zero width no-break space 0xFEFF \uFEFF tag space 0xE0020 \uDB40\uDC20
Removed extra symbols from a space regex, now it works only for:
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the case, where user with an address "user@gmail.co m" was approved by the validator. Added checking for space symbols.