Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isMobilePhone): add dutch phone number format #923

Closed
wants to merge 1 commit into from
Closed

fix(isMobilePhone): add dutch phone number format #923

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 3, 2018

Hi, love your library! Here's dutch phone number. Let me know do you need anything else to be changed in this pr to merge :)

@chriso
Copy link
Collaborator

chriso commented Nov 4, 2018

Thank you! 😄

Do you mind updating the README and adding some unit tests?

@chriso chriso added the 🧹 needs-update For PRs that need to be updated before landing label Nov 4, 2018
@profnandaa
Copy link
Member

@odrzutowiec - ping!

@mayurssoni2456
Copy link

Need support for Dutch locale. Not sure why this PR is open. Please help.

@profnandaa
Copy link
Member

@mayurssoni2456 -- cleaning this up, should be in the next release, in a few weeks.

profnandaa added a commit to profnandaa/validator.js that referenced this pull request Jul 2, 2019
@profnandaa profnandaa mentioned this pull request Jul 2, 2019
@profnandaa profnandaa closed this in 1a2a868 Jul 2, 2019
@ghost
Copy link
Author

ghost commented Jul 2, 2019

Yes, sorry guys I didn't follow up on this. 🙈 Good luck!

@profnandaa
Copy link
Member

@odrzutowiec -- no worries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 needs-update For PRs that need to be updated before landing stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants