[CRASH] When loading module-oss (RediSearch with Coordinator), Valkey Node crashes #1054
Assignees
Comments
|
The bug is here: Line 3249 in d9c41e9
|
enjoy-binbin
added a commit
to enjoy-binbin/valkey
that referenced
this issue
Sep 23, 2024
The reason is VM_Call will use a fake client without connection, so we also need to check if c->conn is NULL. Fixes valkey-io#1054. Signed-off-by: Binbin <binloveplay1314@qq.com>
madolson
pushed a commit
that referenced
this issue
Sep 27, 2024
) moduleTimerHandler is aeTimeProc handler and event loop gets created with this. However, found that the function return type is int but actually returns "long long" value(i.e., next_period). and return value being assigned to int variable in processTimeEvents(where time events are processed), this might cause an overflow of the timer values. So changed the return type of the function to long long. And also updated other callback function return type to be consistent. I found this when I was checking functions reported in #1054 issue stacktrace. (FYI, this is just to update the return type to be consistent and it will not the fix for the issue reported) Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
madolson
pushed a commit
to madolson/valkey
that referenced
this issue
Sep 30, 2024
…sh (valkey-io#1063) The reason is VM_Call will use a fake client without connection, so we also need to check if c->conn is NULL. This also affects scripts. If they are called in the script, the server will crash. Injecting commands into AOF will also cause startup failure. Fixes valkey-io#1054. Signed-off-by: Binbin <binloveplay1314@qq.com>
naglera
pushed a commit
to naglera/placeholderkv
that referenced
this issue
Oct 10, 2024
…sh (valkey-io#1063) The reason is VM_Call will use a fake client without connection, so we also need to check if c->conn is NULL. This also affects scripts. If they are called in the script, the server will crash. Injecting commands into AOF will also cause startup failure. Fixes valkey-io#1054. Signed-off-by: Binbin <binloveplay1314@qq.com> Signed-off-by: naglera <anagler123@gmail.com>
naglera
pushed a commit
to naglera/placeholderkv
that referenced
this issue
Oct 10, 2024
…lkey-io#1057) moduleTimerHandler is aeTimeProc handler and event loop gets created with this. However, found that the function return type is int but actually returns "long long" value(i.e., next_period). and return value being assigned to int variable in processTimeEvents(where time events are processed), this might cause an overflow of the timer values. So changed the return type of the function to long long. And also updated other callback function return type to be consistent. I found this when I was checking functions reported in valkey-io#1054 issue stacktrace. (FYI, this is just to update the return type to be consistent and it will not the fix for the issue reported) Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com> Signed-off-by: naglera <anagler123@gmail.com>
eifrah-aws
pushed a commit
to eifrah-aws/valkey
that referenced
this issue
Oct 20, 2024
…lkey-io#1057) moduleTimerHandler is aeTimeProc handler and event loop gets created with this. However, found that the function return type is int but actually returns "long long" value(i.e., next_period). and return value being assigned to int variable in processTimeEvents(where time events are processed), this might cause an overflow of the timer values. So changed the return type of the function to long long. And also updated other callback function return type to be consistent. I found this when I was checking functions reported in valkey-io#1054 issue stacktrace. (FYI, this is just to update the return type to be consistent and it will not the fix for the issue reported) Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Crash report
Additional information
The text was updated successfully, but these errors were encountered: