Speed up AOF rewrite test case #1093
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two test cases run in a loop: * AOF rewrite during write load: RDB preamble=yes * AOF rewrite during write load: RDB preamble=no Both of the test cases build up a lot of data (3-4 million keys when I run locally) so we should empty the data before the second test case. Otherwise, the second test cases adds keys on top of the keys added in the first test case, resulting in the double number of keys and takes more time. Before this commit: [ok]: AOF rewrite during write load: RDB preamble=yes (18225 ms) [ok]: AOF rewrite during write load: RDB preamble=no (37249 ms) After: [ok]: AOF rewrite during write load: RDB preamble=yes (18777 ms) [ok]: AOF rewrite during write load: RDB preamble=no (19940 ms) Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1093 +/- ##
============================================
- Coverage 70.61% 70.44% -0.17%
============================================
Files 114 114
Lines 61694 61694
============================================
- Hits 43564 43462 -102
- Misses 18130 18232 +102 |
enjoy-binbin
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two test cases run in a loop:
Both of the test cases build up a lot of data (3-4 million keys when I run locally) so we should empty the data before the second test case. Otherwise, the second test cases adds keys on top of the keys added in the first test case, resulting in the double number of keys and takes more time.
Before this commit:
After: