Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid double close on replica main channel #1097

Merged

Conversation

ranshid
Copy link
Member

@ranshid ranshid commented Sep 30, 2024

fixes #1088

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Copy link
Member

@PingXie PingXie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ranshid!

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.62%. Comparing base (a7cbca4) to head (ec137c3).
Report is 1 commits behind head on unstable.

Files with missing lines Patch % Lines
src/replication.c 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1097      +/-   ##
============================================
+ Coverage     70.48%   70.62%   +0.13%     
============================================
  Files           114      114              
  Lines         61694    61695       +1     
============================================
+ Hits          43488    43572      +84     
+ Misses        18206    18123      -83     
Files with missing lines Coverage Δ
src/replication.c 87.34% <0.00%> (-0.17%) ⬇️

... and 12 files with indirect coverage changes

@PingXie PingXie merged commit c873287 into valkey-io:unstable Sep 30, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] server.repl__transfer_s is double-closed/freed in fullSyncWithPrimary
3 participants