Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor repldbfd leak in updateReplicasWaitingBgsave if fstat fails #1226

Merged
merged 1 commit into from
Oct 27, 2024

Commits on Oct 25, 2024

  1. Fix minor repldbfd leak in updateReplicasWaitingBgsave if fstat fails

    In the old code, if fstat fails, replica->repldbfd will hold the
    fd and we are doing a free client. And in freeClient, we check and
    close only if repl_state == REPLICA_STATE_SEND_BULK. So if fstat
    fails, we will leak the fd.
    
    We can also extend freeClient to handle REPLICA_STATE_WAIT_BGSAVE_END
    as well, but here seems to be a more friendly (and safer) way.
    
    Signed-off-by: Binbin <binloveplay1314@qq.com>
    enjoy-binbin committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    cf1ba15 View commit details
    Browse the repository at this point in the history