Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory inspection commands no longer return loading errors #1317

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

knggk
Copy link
Contributor

@knggk knggk commented Nov 18, 2024

Fixes #1299

Signed-off-by: Guillaume Koenig <knggk@amazon.com>
@knggk knggk force-pushed the memory-commands-during-loading branch from 6b826d4 to 09d475d Compare November 18, 2024 22:31
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.68%. Comparing base (aa2dd3e) to head (09d475d).
Report is 3 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1317      +/-   ##
============================================
- Coverage     70.73%   70.68%   -0.05%     
============================================
  Files           115      115              
  Lines         63158    63159       +1     
============================================
- Hits          44674    44646      -28     
- Misses        18484    18513      +29     
Files with missing lines Coverage Δ
src/commands.def 100.00% <ø> (ø)

... and 16 files with indirect coverage changes

---- 🚨 Try these New Features:

@hwware
Copy link
Member

hwware commented Nov 19, 2024

I would like to suggest only 3 commands except "memory stats" to be allowed during loading process because it costs a lot of resources and involves key issues. (key count, key used memory)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MEMORY DOCTOR/MALLOC-STATS in loading phase
2 participants