-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'Redis' in error replies #206
Remove 'Redis' in error replies #206
Conversation
This includes error message like * "-MISCONF Redis is configured to save RDB snapshots (...)" * "-LOADING Redis is loading the dataset in memory" * "-BUSY Redis is busy running a script (...)" but also error replies from `redis.call` in a Lua script, such as * "Please specify at least one argument for this redis lib call" * "Wrong number of args calling Redis command from script" * "Unknown Redis command called from script" * "Invalid command passed to redis.acl_check_cmd()" The name Redis is simply removed from these error message. In the last one above, "redis.acl_check_cmd()" is replaced by "server.acl_check_cmd()" in the error message. Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@0del do you want to review this one? |
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
ca07ce1
to
4ac8a77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
I don't think we should make this change. We should use the indirection mechanism established in #47 instead. As we discussed in other threads, I am proposing to have one uber compilation flag such as '-DREDIS_COMAPT=1' to control the presence/absence of all breaking changes. |
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
b169043
to
7b73d8d
Compare
Low-risk error replies containing "Redis" are changed. In most cases, the word "Redis" is simply removed from the error message, such as in "This Redis instance is not configured to use an ACL file. (...)", the message is changed to "This instance is not configured to use an ACL file. (...)". Additionally, error replies from `redis.call` in a Lua script are affected, such as * "Please specify at least one argument for this redis lib call" * "Wrong number of args calling Redis command from script" * "Unknown Redis command called from script" * "Invalid command passed to redis.acl_check_cmd()" The name Redis is simply removed from these error message. In the last one above, "redis.acl_check_cmd()" is replaced by "server.acl_check_cmd()" in the error message. The following error replies are considered high of causing problems for clients, so they are not changed in this commit: * (not in scope) "-MISCONF Redis is configured to save RDB snapshots (...)" * (not in scope) "-LOADING Redis is loading the dataset in memory" * (not in scope) "-BUSY Redis is busy running a script (...)" Fixes valkey-io#204 --------- Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Low-risk error replies containing "Redis" are changed. In most cases, the word "Redis" is simply removed from the error message, such as in "This Redis instance is not configured to use an ACL file. (...)", the message is changed to "This instance is not configured to use an ACL file. (...)". Additionally, error replies from `redis.call` in a Lua script are affected, such as * "Please specify at least one argument for this redis lib call" * "Wrong number of args calling Redis command from script" * "Unknown Redis command called from script" * "Invalid command passed to redis.acl_check_cmd()" The name Redis is simply removed from these error message. In the last one above, "redis.acl_check_cmd()" is replaced by "server.acl_check_cmd()" in the error message. The following error replies are considered high of causing problems for clients, so they are not changed in this commit: * (not in scope) "-MISCONF Redis is configured to save RDB snapshots (...)" * (not in scope) "-LOADING Redis is loading the dataset in memory" * (not in scope) "-BUSY Redis is busy running a script (...)" Fixes valkey-io#204 --------- Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Low-risk error replies containing "Redis" are changed, excluding the following ones that are instead covered in #274 (since they're high risk of causing problems):
Additionally, error replies from
redis.call
in a Lua script are affected, such asThe name Redis is simply removed from these error message. In the last one above, "redis.acl_check_cmd()" is replaced by "server.acl_check_cmd()" in the error message.
Fixes #204
For release notes: