List test files dynamically

[dev-jonghoonpark]

Related issue: #302

Motivation: Currently we have to manually update the all_tests variable when introducing new test files.

Fix: I've modified it to list test files dynamically, but rather than modify it to add all test files, I've first modified it to only add test files from the following 4 paths so that it doesn't deviate too much from what we already do

• unit
• unit/type
• unit/cluster
• integration

The result: Previously, 92 tests were in the all_tests variable.
Currently, 93 tests from the four paths mentioned above are in the all_tests variable (unit/type/list-common was added. the rest is the same).

[zuiderkwast]

unit/type/list-common doesn't contain tests. It just defines some variables. I think we should move it out, to tests/helpers/ or whatevever.

[dev-jonghoonpark]

unit/type/list-common doesn't contain tests. It just defines some variables. I think we should move it out, to tests/helpers/ or whatevever.

Currently, the unit/type/list-common file is used in three places.

• tests/unit/keyspace.tcl
• tests/unit/type/list.tcl
• tests/unit/type/list-2.tcl

what about move to tests/includes?

@zuiderkwast @madolson

[madolson]

what about move to tests/includes?

I would just throw it at the bottom of support/util.tcl and remove all the special includes. Right now we just throw alls sorts of random stuff there.

[zuiderkwast]

what about move to tests/includes?

I would just throw it at the bottom of support/util.tcl and remove all the special includes. Right now we just throw alls sorts of random stuff there.

Yes but let's wrap it in a function to return that big array, right? Now it's just creating it when included. Another option is to duplicate those 3(?) lines in all test suites using it.

[dev-jonghoonpark]

After removing list-common.tcl, I created a function in util.tcl.

Can you check the changes?
@madolson

[hpatro]

LGTM

[enjoy-binbin]

CI failed:

*** [err]: Is a ziplist encoded Hash promoted on big payload? in tests/unit/type/hash.tcl
Expected '*hashtable*' to equal or match 'Value at:0x7f0edf3d2300 refcount:1 encoding:listpack serializedlength:178 lru:1871839 lru_seconds_idle:0'

[madolson]

CI failed:

It's probably a test ordering issue. Since the external test re-uses the same cluster, there was probably a config that was set on an earlier test that is interfering with it. You probably juts need to reset the hash-max-listpack-value back to the default value to get the test to pass.

[dev-jonghoonpark]

It's probably a test ordering issue. Since the external test re-uses the same cluster, there was probably a config that was set on an earlier test that is interfering with it. You probably juts need to reset the hash-max-listpack-value back to the default value to get the test to pass.

Thanks for the hint. I knew it had something to do with the order, but I wasn't sure where to look.

I'll try some more.

@madolson

[dev-jonghoonpark]

Added a line to reset the hash-max-listpack-value value to 64 (the default value as stated in valkey.conf)

I tested on the forked repository and confirmed that it passes.

@madolson

[daniel-house]

what about move to tests/includes?

I would just throw it at the bottom of support/util.tcl and remove all the special includes. Right now we just throw alls sorts of random stuff there.

Phrases like "just throw" and "random stuff" give me nervous twitches. As far as I can tell, that's how we got server.h.