Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cluster cant failover log conditions #780

Merged

Commits on Jul 13, 2024

  1. Improve cluster cant failover log conditions

    This PR adjusts the logging conditions of clusterLogCantFailover
    in this two ways.
    
    1. For the same cant_failover_reason, we will print the log once
    in CLUSTER_CANT_FAILOVER_RELOG_PERIOD, but its value is 10s, which
    is a bit long, shorten it to 5s, so we can better track its state.
    
    2. We will not print logs before the nolog_fail_time, its value
    is cluster-node-timeout+5000. This may casue us to lose some logs,
    for example, if cluster-node-timeout is small, auth_timeout will
    be 2000, and auth_retry_time will be 4000. In this case, we will
    lose all the reasons during the election if the failover is timedout.
    So remove the nolog_fail_time logic, since we still do have the
    CLUSTER_CANT_FAILOVER_RELOG_PERIOD logic, We won't print too many
    logs.
    
    Signed-off-by: Binbin <binloveplay1314@qq.com>
    enjoy-binbin committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    6c3e00a View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. change CLUSTER_CANT_FAILOVER_RELOG_PERIOD to 1s

    Signed-off-by: Binbin <binloveplay1314@qq.com>
    enjoy-binbin committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9e050f8 View commit details
    Browse the repository at this point in the history