Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual channel replication should not update lastbgsave_status when transfer error #811

Merged
merged 1 commit into from
Aug 12, 2024

Commits on Jul 22, 2024

  1. Dual channel replication should not update lastbgsave_status when tra…

    …nsfer error
    
    Currently lastbgsave_status is used in bgsave or disk-replication,
    and the target is the disk. In valkey-io#60, we update it when transfer error,
    i think it is mainly used in tests, so we can use log to replace it.
    
    It changes lastbgsave_status to err in this case, but it is strange
    that it does not set ok or err in the above if and the following else.
    Also noted this will affect stop-writes-on-bgsave-error.
    
    Signed-off-by: Binbin <binloveplay1314@qq.com>
    enjoy-binbin committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    b8d3809 View commit details
    Browse the repository at this point in the history