Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude '.' and ':' from isValidAuxChar's banned charset #963

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Exclude '.' and ':' from isValidAuxChar's banned charset #963

merged 2 commits into from
Aug 29, 2024

Commits on Aug 29, 2024

  1. Fix a bug in isValidAuxChar where valid characters '.' and ':' were i… 

    …ncorrectly

included in the banned charset. This issue affected the validation of auxiliary
fields in the nodes.conf file used by Valkey in cluster mode, particularly when
handling IPv4 and IPv6 addresses. The code now correctly allows '.' and ':' as
valid characters, ensuring proper handling of these fields. Comments were added
to clarify the use of the banned charset.

Signed-off-by: Ping Xie <pingxie@google.com>
    @PingXie
    PingXie committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    8e3e554 View commit details
    Browse the repository at this point in the history

  2. Split ipv4 and ipv6 tests 

    Signed-off-by: Ping Xie <pingxie@google.com>
    @PingXie
    PingXie committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    9ff7e5f View commit details
    Browse the repository at this point in the history