Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FDJUMP parameters to the designmmatrix #64

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

siyuan-chen
Copy link
Collaborator

@siyuan-chen siyuan-chen commented Jun 20, 2024

For the IPTA DR3 combination new parameters describing DM offsets between different PTA data sets have been introduced in tempo2: FDJUMP and FDJUMPDM
https://bitbucket.org/psrsoft/tempo2/pull-requests/84
and related pull requests in tempo2

This PR adds these FDJUMPX parameters to libstempo, such they are included in the designmatrix and can be passed to enterprise.
The structure follows the normal phase JUMP parameters with FDJUMP and FDJUMPDM parameters being called numbered FDJUMPX in libstempo.

@mattpitkin
Copy link
Collaborator

@siyuan-chen do you want to get this PR merged in before a new release is made? It's probably worth rebasing this branch with master now #69 is merged and making sure the CI tests now run.

@siyuan-chen
Copy link
Collaborator Author

siyuan-chen commented Jul 24, 2024

yes, thanks for the reminder, Matt. Actually, this still needs some testing to be sure that it works properly with tempo2. So, not urgent for now.
As I mentioned in the other #69 , feel free to go ahead with 3.5.0. Once the PRs to add the new functionality from tempo2 are done, we can update to 3.5.X.

@mattpitkin
Copy link
Collaborator

I've released v2.5.0 on PyPI now and will update the conda installable version too.

@siyuan-chen
Copy link
Collaborator Author

Hi @mattpitkin , I think this PR is fine to be merged. (there is an error in one of the tests, I don't see why it happens though)

@mattpitkin
Copy link
Collaborator

I re-ran the test that failed and it seemed to work.

@siyuan-chen
Copy link
Collaborator Author

Thanks for having a look, Matt. We can have this on the master branch for a while and if there are no bugs found, we can make a version 2.5.1. And that should be the version for the IPTA DR3 work.

@mattpitkin mattpitkin merged commit a6098e3 into vallis:master Sep 5, 2024
12 checks passed
@mattpitkin
Copy link
Collaborator

I've merged this in now and am happy to wait and see if there are any fixes required before publishing a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants