Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typeahead): Tab does not behave as click in field at Typeahead component #490

Closed
Jeetah opened this issue May 9, 2016 · 10 comments · Fixed by #715
Closed

fix(typeahead): Tab does not behave as click in field at Typeahead component #490

Jeetah opened this issue May 9, 2016 · 10 comments · Fixed by #715
Assignees

Comments

@Jeetah
Copy link

Jeetah commented May 9, 2016

Changing with Tab into the Typeahead field should work as clicking with the mouse into it.
Currently Tab triggers always a search - event if there is nothing in the field (which could also lead to crashes if model is still undefined).
Also Tab in Typeahead popup/dropdown does not behave like Enter/Click.

@Dinistro
Copy link
Contributor

@Jeetah This should work just fine. What Browser are you using?

@Jeetah
Copy link
Author

Jeetah commented Jun 1, 2016

Chrome - I will test it again with latest version and report back

@Jeetah
Copy link
Author

Jeetah commented Jun 3, 2016

Verified: Tab triggers search event now only if there exists a value in the field. But this makes no sense - it should only trigger if the user enters something new.

PS: Tab in popup works now as expected.

@valorkin valorkin changed the title Tab does not behave as click in field at Typeahead component fix(typeahead): Tab does not behave as click in field at Typeahead component Jun 6, 2016
rbaarsma added a commit to rbaarsma/ng2-bootstrap that referenced this issue Jul 5, 2016
rbaarsma added a commit to rbaarsma/ng2-bootstrap that referenced this issue Jul 5, 2016
valorkin pushed a commit that referenced this issue Jul 11, 2016
…B. TAB should simply skip to next field as expected.

fixes #686, fixes  #490, closes #689
@valorkin valorkin self-assigned this Jul 11, 2016
valorkin added a commit that referenced this issue Jul 11, 2016
…B. TAB should simply skip to next field as expected. (#715)

fixes #686, fixes  #490, closes #689
@karthikv-26
Copy link

karthikv-26 commented Sep 7, 2017

@valorkin
First of all thanks for this great library.
I see the issue for skipping tab event triggering search is fixed and merged. When would this be available through NPM? I see the current(Latest) version still does not have this fix.

@valorkin
Copy link
Member

valorkin commented Sep 7, 2017

Current Typeahead implementation is over complicated, we are preparing for v2 of ngx bs, and first big thing will be completely new, Typeahead

@karthikv-26
Copy link

@valorkin Thank you for the quick reply.. Any info when are you planning for the release of v2.. Just to plan things from our end..

@valorkin
Copy link
Member

valorkin commented Sep 7, 2017

v1.9.2 was last big version of ngx bs,
Starting from tomorrow we will work on v2
I would say v2 will be just a middleware before v3

@karthikv-26
Copy link

@valorkin Can there be any patch release for v1.9.x for this tab key handling for typeahead. Because as of now everything else in the typeahead looks stable.

@valorkin
Copy link
Member

valorkin commented Sep 7, 2017

in v2 will focus trap, and it will be applied to such elements, for more correct keyboard handling

@karthikv-26
Copy link

@valorkin Thank you..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants