-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typeahead): Tab does not behave as click in field at Typeahead component #490
Comments
@Jeetah This should work just fine. What Browser are you using? |
Chrome - I will test it again with latest version and report back |
Verified: Tab triggers search event now only if there exists a value in the field. But this makes no sense - it should only trigger if the user enters something new. PS: Tab in popup works now as expected. |
…mply skip to next field as expected. Solves valor-software#686 and valor-software#490
…mply skip to next field as expected. Solves valor-software#686 and valor-software#490
@valorkin |
Current Typeahead implementation is over complicated, we are preparing for v2 of ngx bs, and first big thing will be completely new, Typeahead |
@valorkin Thank you for the quick reply.. Any info when are you planning for the release of v2.. Just to plan things from our end.. |
v1.9.2 was last big version of ngx bs, |
@valorkin Can there be any patch release for v1.9.x for this tab key handling for typeahead. Because as of now everything else in the typeahead looks stable. |
in v2 will focus trap, and it will be applied to such elements, for more correct keyboard handling |
@valorkin Thank you.. |
Changing with Tab into the Typeahead field should work as clicking with the mouse into it.
Currently Tab triggers always a search - event if there is nothing in the field (which could also lead to crashes if model is still undefined).
Also Tab in Typeahead popup/dropdown does not behave like Enter/Click.
The text was updated successfully, but these errors were encountered: