Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typeahead TAB unwanted behavior #686

Closed
rbaarsma opened this issue Jul 4, 2016 · 2 comments · Fixed by #715
Closed

Typeahead TAB unwanted behavior #686

rbaarsma opened this issue Jul 4, 2016 · 2 comments · Fixed by #715
Assignees

Comments

@rbaarsma
Copy link
Contributor

rbaarsma commented Jul 4, 2016

The typeahead specifically selects the active match when pressing TAB, but I think this is simply wrong.

ENTER should select the active match (as it does)
TAB should not select anything and simply move to the next field (default behavior)

To fix this only a single line needs to change in typeahead.directive.ts:
145 this.container.selectActiveMatch();
==>
145 this.hide()

If you guys agree I could make a pull request, but it would be simpler for me if someone from the core team can just fix it ;)

@Dinistro
Copy link
Contributor

Dinistro commented Jul 5, 2016

In #490 someone asked to add this "feature".

rbaarsma added a commit to rbaarsma/ng2-bootstrap that referenced this issue Jul 5, 2016
rbaarsma added a commit to rbaarsma/ng2-bootstrap that referenced this issue Jul 5, 2016
valorkin pushed a commit that referenced this issue Jul 11, 2016
…B. TAB should simply skip to next field as expected.

fixes #686, fixes  #490, closes #689
@valorkin valorkin self-assigned this Jul 11, 2016
valorkin added a commit that referenced this issue Jul 11, 2016
…B. TAB should simply skip to next field as expected. (#715)

fixes #686, fixes  #490, closes #689
@karthikv-26
Copy link

@rbaarsma Any idea on when would this fix be available to download through NPM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants