Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown adding 'active' class when isOpen #1415

Closed
rpdmiranda opened this issue Dec 29, 2016 · 2 comments
Closed

Dropdown adding 'active' class when isOpen #1415

rpdmiranda opened this issue Dec 29, 2016 · 2 comments

Comments

@rpdmiranda
Copy link

Dropdown component is adding 'open' and 'active' classes when a dropdown is opened. The 'active' class is also used in navbars, to mark which item is active. That way, it's difficult to use the dropdown component in menus.

May the @HostBinding('class.active') be removed?

@patrick-mackay
Copy link

We're having the same issue here. Bootstrap only uses "open" on the

  • , but ng2-bootstrap is adding also the "active" class. We have some css that are being activated with the active class.

    following rpdmiranda's pointer, removing

    webpack_require.i(WEBPACK_IMPORTED_MODULE_0__angular_core["HostBinding"])('class.active'), (line 4965)

    from ng2-bootstrap.umd.js, and I guess that removing

    "{ type: HostBinding, args: ['class.active',] },"

    from dropdown.directive.js (line 157) will do the trick before bundling.

    Any chance to get this change? I could do a PR but not sure its worthwhile for such a small change.

  • @nsobral
    Copy link

    nsobral commented Feb 13, 2017

    same issue

    valorkin added a commit that referenced this issue Mar 24, 2017
    fixes #1674, fixes #1749, fixes #1623, fixes #1415, fixes #802, fixes #569, fixes #530, fixes #6,
    fixes #1540, fixes #1217, fixes #591, fixes #478
    valorkin added a commit that referenced this issue Mar 24, 2017
    fixes #1674, fixes #1749, fixes #1623, fixes #1415, fixes #802, fixes #569, fixes #530, fixes #6,
    fixes #1540, fixes #1217, fixes #591, fixes #478
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants