-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown adding 'active' class when isOpen #1415
Comments
We're having the same issue here. Bootstrap only uses "open" on the following rpdmiranda's pointer, removing webpack_require.i(WEBPACK_IMPORTED_MODULE_0__angular_core["HostBinding"])('class.active'), (line 4965) from ng2-bootstrap.umd.js, and I guess that removing "{ type: HostBinding, args: ['class.active',] }," from dropdown.directive.js (line 157) will do the trick before bundling. Any chance to get this change? I could do a PR but not sure its worthwhile for such a small change. |
same issue |
Dropdown component is adding 'open' and 'active' classes when a dropdown is opened. The 'active' class is also used in navbars, to mark which item is active. That way, it's difficult to use the dropdown component in menus.
May the
@HostBinding('class.active')
be removed?The text was updated successfully, but these errors were encountered: