Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(timepicker): allow null value and change validation state on manual update #3084

Merged
merged 1 commit into from
Nov 21, 2017

Conversation

valorkin
Copy link
Member

@valorkin valorkin commented Nov 21, 2017

fixes #2907

go to:
http://localhost:4200/#/timepicker#dynamic

  1. clean button should clean timepicker value
  2. manually time 12:aa (invalid time, should mark field as not valid)
    this is kinda dirty

@EvilAlexei please add timepicker validation to v2 roadmap

@codecov
Copy link

codecov bot commented Nov 21, 2017

Codecov Report

Merging #3084 into development will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3084      +/-   ##
===============================================
- Coverage        65.54%   65.52%   -0.02%     
===============================================
  Files              209      209              
  Lines             5604     5607       +3     
  Branches           985      986       +1     
===============================================
+ Hits              3673     3674       +1     
- Misses            1669     1671       +2     
  Partials           262      262
Impacted Files Coverage Δ
src/timepicker/timepicker.component.ts 91.74% <33.33%> (-1.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7616362...e27a246. Read the comment docs.

@YevheniiaMazur
Copy link

Tested, looks good

@valorkin valorkin merged commit 0d72cd6 into development Nov 21, 2017
@valorkin valorkin deleted the feat-timepicker-allow-null branch November 21, 2017 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimePicker - Set initial value to NULL
2 participants