Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(timepicker): reseting timepicker if ng-model set to null #2914

Closed
wants to merge 3 commits into from
Closed

feat(timepicker): reseting timepicker if ng-model set to null #2914

wants to merge 3 commits into from

Conversation

felipe-mena
Copy link

@felipe-mena felipe-mena commented Oct 25, 2017

Refresh component in case the binding property is set to null.
showReset input has been added to the component that shows a button to reset the value to null.

The locale "sv" has been removed because of an error message when trying to run the application (file is missing).

fixes #2907

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

Refresh component in case the binding property is set to null.
showReset input has been added to the component that shows a button to reset the value to null.

The locale "sv" has been removed because of an error message when trying to run the application (file is missing).
@valorkin valorkin changed the title Solution: issue #2907 feat(timepicker): reseting timepicker if ng-model set to null Oct 27, 2017
@valorkin
Copy link
Member

@felipemena1 hey, thanks for contribution
please fix sv locale, and test before we can move this PR further

@valorkin
Copy link
Member

thanks again for PR, closing in favour of: #3084

@valorkin valorkin closed this Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimePicker - Set initial value to NULL
2 participants