Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): focus modal container on init #3357

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Conversation

IlyaSurmay
Copy link
Contributor

Fixes #3356

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.

@codecov
Copy link

codecov bot commented Dec 25, 2017

Codecov Report

Merging #3357 into development will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development   #3357      +/-   ##
==============================================
- Coverage        65.03%     65%   -0.03%     
==============================================
  Files              210     210              
  Lines             5691    5693       +2     
  Branches          1000    1001       +1     
==============================================
  Hits              3701    3701              
- Misses            1724    1726       +2     
  Partials           266     266
Impacted Files Coverage Δ
src/modal/modal-container.component.ts 19.29% <0%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a747c...e53742d. Read the comment docs.

@valorkin valorkin added this to the v2.0.0-rc.2 milestone Jan 5, 2018
@valorkin valorkin merged commit dd33e63 into development Jan 5, 2018
@valorkin valorkin deleted the fix-modal-focus branch January 5, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants