Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): added Thai locale support for datepicker #3409

Merged
merged 6 commits into from
Jan 12, 2018
Merged

feat(datepicker): added Thai locale support for datepicker #3409

merged 6 commits into from
Jan 12, 2018

Conversation

tumit
Copy link
Contributor

@tumit tumit commented Jan 7, 2018

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Jan 7, 2018

Codecov Report

Merging #3409 into development will decrease coverage by 0.34%.
The diff coverage is 66.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3409      +/-   ##
===============================================
- Coverage        72.83%   72.48%   -0.35%     
===============================================
  Files              248      249       +1     
  Lines             8009     8060      +51     
  Branches          1412     1527     +115     
===============================================
+ Hits              5833     5842       +9     
+ Misses            1823     1795      -28     
- Partials           353      423      +70
Impacted Files Coverage Δ
src/index.ts 100% <100%> (ø) ⬆️
src/locale.ts 100% <100%> (ø) ⬆️
src/bs-moment/i18n/th.ts 33.33% <33.33%> (ø)
src/dropdown/bs-dropdown-menu.directive.ts 71.42% <0%> (-28.58%) ⬇️
src/tabs/tab-heading.directive.ts 66.66% <0%> (-13.34%) ⬇️
src/popover/popover-container.component.ts 90.9% <0%> (-9.1%) ⬇️
src/carousel/slide.component.ts 91.66% <0%> (-8.34%) ⬇️
src/tabs/ng-transclude.directive.ts 60% <0%> (-6.67%) ⬇️
src/popover/popover.directive.ts 82.14% <0%> (-6.32%) ⬇️
src/progressbar/progressbar.component.ts 93.75% <0%> (-6.25%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3de13fb...cc0f16e. Read the comment docs.

@ghost ghost assigned valorkin Jan 12, 2018
@ghost ghost added the in progress label Jan 12, 2018
@valorkin valorkin merged commit 662d8c1 into valor-software:development Jan 12, 2018
@ghost ghost removed the in progress label Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants