Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): add cypress e2e tests instead of protractor e2e and e2e-bdd tests #3515

Merged
merged 4 commits into from
Feb 5, 2018

Conversation

YevheniiaMazur
Copy link

@YevheniiaMazur YevheniiaMazur commented Jan 22, 2018

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost assigned YevheniiaMazur Jan 22, 2018
@ghost ghost added the in progress label Jan 22, 2018
@codecov
Copy link

codecov bot commented Jan 22, 2018

Codecov Report

Merging #3515 into development will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3515      +/-   ##
===============================================
+ Coverage        72.07%   72.09%   +0.02%     
===============================================
  Files              251      251              
  Lines             8142     8142              
  Branches          1544     1544              
===============================================
+ Hits              5868     5870       +2     
+ Misses            1851     1850       -1     
+ Partials           423      422       -1
Impacted Files Coverage Δ
src/chronos/i18n/pl.ts 77.77% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c09f0f9...600a8b9. Read the comment docs.

@YevheniiaMazur YevheniiaMazur force-pushed the feat-add-cypress-example branch 4 times, most recently from 6cd93c7 to 737d362 Compare January 24, 2018 16:48
@YevheniiaMazur YevheniiaMazur force-pushed the feat-add-cypress-example branch 3 times, most recently from 3617f70 to 52c83ba Compare January 25, 2018 12:08
@YevheniiaMazur YevheniiaMazur changed the title WIP feat(tests): add cypress e2e tests instead of protractor e2e and e2e-bdd tests feat(tests): add cypress e2e tests instead of protractor e2e and e2e-bdd tests Jan 25, 2018

landing.navigateTo();

cy.get(buttonSelector).eq(0).should('be.enabled');

This comment was marked as off-topic.


landing.navigateTo();

cy.get('.btn').contains(buttonText).should('be.enabled');

This comment was marked as off-topic.

@YevheniiaMazur YevheniiaMazur force-pushed the feat-add-cypress-example branch 2 times, most recently from 28993ea to 50c7e9c Compare January 29, 2018 18:01
@YevheniiaMazur YevheniiaMazur changed the title feat(tests): add cypress e2e tests instead of protractor e2e and e2e-bdd tests WIP feat(tests): add cypress e2e tests instead of protractor e2e and e2e-bdd tests Jan 29, 2018
@YevheniiaMazur YevheniiaMazur force-pushed the feat-add-cypress-example branch 2 times, most recently from 866f934 to d03a8c0 Compare January 30, 2018 14:49
@YevheniiaMazur YevheniiaMazur force-pushed the feat-add-cypress-example branch 3 times, most recently from 797da13 to aae67f0 Compare February 1, 2018 12:42
@valorkin valorkin changed the title WIP feat(tests): add cypress e2e tests instead of protractor e2e and e2e-bdd tests feat(tests): add cypress e2e tests instead of protractor e2e and e2e-bdd tests Feb 5, 2018
@valorkin valorkin removed the WIP label Feb 5, 2018
@valorkin valorkin merged commit 4ff55ce into development Feb 5, 2018
@ghost ghost removed the in progress label Feb 5, 2018
@valorkin valorkin deleted the feat-add-cypress-example branch February 5, 2018 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants