Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated: rxjs for typeahead component #99

Closed

Conversation

buchslava
Copy link
Member

No description provided.

@valorkin
Copy link
Member

#92 #89 #61 #41

@koodikindral
Copy link

Any progress with that?

@valorkin
Copy link
Member

yeap, will be published

@Systho
Copy link

Systho commented Apr 20, 2016

Any news on this PR ?

@@ -6,13 +6,13 @@ import {
} from 'angular2/core';
import {NgModel}from 'angular2/common';

import {Observable, Subject} from 'rxjs/Rx';

This comment was marked as off-topic.

This comment was marked as off-topic.

@valorkin
Copy link
Member

this one most probably will not be merged
because extensive rxjs usage requires additional configuration
by ng2-bootstrap consumers

@Dinistro
Copy link
Contributor

Dinistro commented May 20, 2016

RxJS is in my opinion the way to go. If the async typeahead is used, the searching will mostly use http and this returns an Observable. Observables support a ton of very useful operators that can be used in the components.
I know that this will need some documentation for all the new consumers, but the current solution is not really practical.

@leon
Copy link

leon commented May 20, 2016

@valorkin Why would it require extra configuration?

if we import the operators distinctUntilChanged and debounceTime, they will be included, and the end user doesn't need to know about them.

@valorkin
Copy link
Member

ok, need to try :)

@Dinistro
Copy link
Contributor

Dinistro commented May 20, 2016

@valorkin If you need a new pull request that works with rc.1, you can inform me. I will hopefuly have some time this weekend.

@valorkin
Copy link
Member

Right now I am fighting with modals
If I win, when I win :)
Any other pop-ups stuff should be a breath
But I will appreciate any help :)

@Dinistro
Copy link
Contributor

@valorkin Work is in progress. This will need some time to test all the stuff. As soon that I'm finished, I will open a new PR.

@valorkin
Copy link
Member

@Dinistro awesome! I will try to finish modals today\tomorrow
today is my Birthday, so hard to say how much time I will have :)

@Dinistro
Copy link
Contributor

@valorkin Happy birthday ;)
I'm finished with the work. Should I create the PR or should I wait until you merged the popup-stuff?

@Dinistro Dinistro mentioned this pull request May 23, 2016
@valorkin
Copy link
Member

I can give you write access so you can create a branch

On Mon, May 23, 2016, 12:24 Christian Ulmann notifications@github.com
wrote:

@valorkin https://github.com/valorkin Happy birthday ;)
I'm finished with the work. Should I create the PR or should I wait until
you merged the popup-stuff?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#99 (comment)

@Dinistro
Copy link
Contributor

Dinistro commented May 23, 2016

@valorkin Would be great. I will merge the changes from #535 into the new branch.

@valorkin
Copy link
Member

@Dinistro welcome to ng2 team :)

@Dinistro
Copy link
Contributor

Dinistro commented Jul 5, 2016

This was merged in another PR: #584

@Dinistro Dinistro closed this Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants