Skip to content

Commit

Permalink
chore(deps): patch react-native-fs with privacy manifest (#5322)
Browse files Browse the repository at this point in the history
### Description

The `react-native-fs` project is no longer maintained, and I don't have
faith that a new version with the changes we need will be published. It
seems like the maintainer of the project has changed but he is now
publishing a fork rather than publishing from this project (context
`https://github.com/itinance/react-native-fs/issues/1197`). The fork has
a lot of
[changes](itinance/react-native-fs@master...birdofpreyru:react-native-fs:master)
and it seems that most projects have _not_ yet migrated to this fork
([low downloads on
npm](https://www.npmjs.com/package/@dr.pogodin/react-native-fs)). I
don't want to make a decision now about which lib to migrate to and
introduce more changes than necessary given the deadline for these
privacy manifest changes. So this PR contains a patch that I made for
the lib, and I used the [same declared
values](https://github.com/birdofpreyru/react-native-fs/blob/master/ios/PrivacyInfo.xcprivacy)
as in the fork (I did also verify that the values seem reasonable).

### Test plan

n/a

### Related issues

- Related to RET-1058

### Backwards compatibility

Y

### Network scalability

If a new NetworkId and/or Network are added in the future, the changes
in this PR will:

- [x] Continue to work without code changes, OR trigger a compilation
error (guaranteeing we find it when a new network is added)
  • Loading branch information
kathaypacific authored Apr 24, 2024
1 parent d99aa51 commit aa417c3
Showing 1 changed file with 52 additions and 0 deletions.
52 changes: 52 additions & 0 deletions patches/react-native-fs+2.20.0.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
diff --git a/node_modules/react-native-fs/PrivacyInfo.xcprivacy b/node_modules/react-native-fs/PrivacyInfo.xcprivacy
new file mode 100644
index 0000000..23f6d7f
--- /dev/null
+++ b/node_modules/react-native-fs/PrivacyInfo.xcprivacy
@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+ <key>NSPrivacyAccessedAPITypes</key>
+ <array>
+ <dict>
+ <key>NSPrivacyAccessedAPIType</key>
+ <string>NSPrivacyAccessedAPICategoryFileTimestamp</string>
+ <key>NSPrivacyAccessedAPITypeReasons</key>
+ <array>
+ <string>0A2A.1</string>
+ </array>
+ </dict>
+ <dict>
+ <key>NSPrivacyAccessedAPITypeReasons</key>
+ <array>
+ <string>85F4.1</string>
+ <string>E174.1</string>
+ </array>
+ <key>NSPrivacyAccessedAPIType</key>
+ <string>NSPrivacyAccessedAPICategoryDiskSpace</string>
+ </dict>
+ </array>
+</dict>
+</plist>
diff --git a/node_modules/react-native-fs/RNFS.xcodeproj/project.pbxproj b/node_modules/react-native-fs/RNFS.xcodeproj/project.pbxproj
index 879b4f4..d7b16cd 100644
--- a/node_modules/react-native-fs/RNFS.xcodeproj/project.pbxproj
+++ b/node_modules/react-native-fs/RNFS.xcodeproj/project.pbxproj
@@ -39,6 +39,7 @@
/* End PBXCopyFilesBuildPhase section */

/* Begin PBXFileReference section */
+ 27C757452BD922EC00C48FEB /* PrivacyInfo.xcprivacy */ = {isa = PBXFileReference; lastKnownFileType = text.xml; path = PrivacyInfo.xcprivacy; sourceTree = "<group>"; };
6456441F1EB8DA9100672408 /* libRNFS.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = libRNFS.a; sourceTree = BUILT_PRODUCTS_DIR; };
8BB364CA1CDA130000435A01 /* Uploader.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Uploader.h; sourceTree = "<group>"; };
8BB364CB1CDA130000435A01 /* Uploader.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = Uploader.m; sourceTree = "<group>"; };
@@ -72,6 +73,7 @@
F12AFB921ADAF8F800E0535D = {
isa = PBXGroup;
children = (
+ 27C757452BD922EC00C48FEB /* PrivacyInfo.xcprivacy */,
F1EB08B91AFD0E6A008F8F2B /* NSArray+Map.h */,
F1EB08BA1AFD0E6A008F8F2B /* NSArray+Map.m */,
F1E59BDD1ADD662800ACA28A /* RNFSManager.h */,

0 comments on commit aa417c3

Please sign in to comment.