Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): rename wallet to app #5895

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

bakoushin
Copy link
Contributor

@bakoushin bakoushin commented Sep 4, 2024

Description

Follow-up to #5879

  • Use the word app instead of wallet in release automation scripts
  • Remove hardcoded links to the Valora wallet repo

Test plan

TBD in a separate branch

Related issues

Backwards compatibility

NA

Network scalability

NA

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.83%. Comparing base (e1fdf60) to head (b133478).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5895      +/-   ##
==========================================
- Coverage   87.84%   87.83%   -0.01%     
==========================================
  Files         730      730              
  Lines       31050    31050              
  Branches     5578     5578              
==========================================
- Hits        27275    27274       -1     
- Misses       3555     3556       +1     
  Partials      220      220              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1fdf60...b133478. Read the comment docs.

Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@bakoushin bakoushin added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 51099bb Sep 4, 2024
15 checks passed
@bakoushin bakoushin deleted the alex/release-automation-rename-wallet-to-app branch September 4, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants