Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): Parameterize whether or not fiatconnect quotes are supported #5919

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

jophish
Copy link
Contributor

@jophish jophish commented Sep 5, 2024

Description

Adds a static config parameter to enable/disable fetching FiatConnect quotes.

Test plan

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.45%. Comparing base (ef8bf39) to head (28a0460).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5919      +/-   ##
==========================================
- Coverage   88.45%   88.45%   -0.01%     
==========================================
  Files         728      728              
  Lines       30665    30668       +3     
  Branches     5516     5517       +1     
==========================================
+ Hits        27124    27126       +2     
- Misses       3335     3336       +1     
  Partials      206      206              
Files with missing lines Coverage Δ
src/config.ts 96.29% <100.00%> (+0.03%) ⬆️
src/fiatExchanges/SelectProvider.tsx 90.77% <100.00%> (+0.09%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef8bf39...28a0460. Read the comment docs.

Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jophish jophish added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 197a29c Sep 5, 2024
15 checks passed
@jophish jophish deleted the jophish/ret-1145 branch September 5, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants