Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sticky home actions #6033

Merged
merged 8 commits into from
Sep 25, 2024
Merged

feat: sticky home actions #6033

merged 8 commits into from
Sep 25, 2024

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented Sep 18, 2024

Description

Home actions contain many important features: send, receive, buy, swap, and withdraw. Currently, if a user has scrolled down in the transaction feed to access the home actions they must scroll to the top of the transaction feed. This causes unnecessary friction when attempting to interact with home actions. As a solution, this PR makes the home actions a sticky header that disappears when scrolled down and reappears as soon as the user starts to scroll back up.

iOS Android
Screen.Recording.2024-09-18.at.9.53.04.AM.mov
Screen.Recording.2024-09-18.at.9.56.00.AM.mov

Test plan

  • Tested locally on iOS
  • Tested locally on Android

Related issues

N/A

Backwards compatibility

Yes

Network scalability

N/A

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (e87d45f) to head (a305b2d).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6033      +/-   ##
==========================================
- Coverage   88.73%   88.73%   -0.01%     
==========================================
  Files         727      727              
  Lines       30772    30763       -9     
  Branches     5306     5306              
==========================================
- Hits        27306    27297       -9     
  Misses       3423     3423              
  Partials       43       43              
Files with missing lines Coverage Δ
src/home/ActionsCarousel.tsx 100.00% <100.00%> (ø)
src/home/TabHome.tsx 98.59% <100.00%> (-0.16%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e87d45f...a305b2d. Read the comment docs.

@MuckT MuckT marked this pull request as ready for review September 18, 2024 23:49
@MuckT MuckT marked this pull request as draft September 19, 2024 00:33
@MuckT MuckT marked this pull request as ready for review September 23, 2024 22:05
Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it 🚀

@MuckT MuckT added this pull request to the merge queue Sep 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 24, 2024
@MuckT MuckT added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit b39180e Sep 25, 2024
15 checks passed
@MuckT MuckT deleted the tomm/sticky-home-actions branch September 25, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants