Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): download Android platform matching the compile SDK version #6053

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

bakoushin
Copy link
Contributor

@bakoushin bakoushin commented Sep 19, 2024

Description

We want to test against Android version provided in the the android-api-level parameter, but the build should always use the compileSdkVersion defined in the build.gradle file.

Test plan

CI succeeds

Related issues

Part of RET-1194

Backwards compatibility

NA

Network scalability

NA

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.67%. Comparing base (6318bb9) to head (c8bbfcc).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6053      +/-   ##
==========================================
- Coverage   88.68%   88.67%   -0.01%     
==========================================
  Files         727      727              
  Lines       30688    30688              
  Branches     5578     5578              
==========================================
- Hits        27216    27213       -3     
+ Misses       3429     3275     -154     
- Partials       43      200     +157     

see 69 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6318bb9...c8bbfcc. Read the comment docs.

@bakoushin bakoushin marked this pull request as ready for review September 19, 2024 16:32
Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@bakoushin bakoushin added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit fbd0547 Sep 19, 2024
16 checks passed
@bakoushin bakoushin deleted the alex/e2e-android-test-use-compile-sdk-version branch September 19, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants